[webkit-reviews] review granted: [Bug 31814] Inconsistent use of counterName and identifier in CSS counter code and loss of information about the counter type. : [Attachment 44587] Proposed Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Carol Szabo <carol.szabo at nokia.com>'s
request for review:
Bug 31814: Inconsistent use of counterName and identifier in CSS counter code
and loss of information about the counter type.
https://bugs.webkit.org/show_bug.cgi?id=31814

Attachment 44587: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=44587&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    // identifier must match the identifier of this counter.
>      void removeChild(CounterNode*, const AtomicString& identifier);

The comment here is worded strangely. You say it must match. That makes it
sound like it's a programming mistake if I pass an identifier that does not
match. I don't think that's how it works.

Maybe this wording: "Does nothing unless the identifier matches the identifier
of the counter."

Or maybe you can think of something better.

r=me