[webkit-reviews] review granted: [Bug 32700] WebSocket: Invalid url should raise SYNTAX_ERR exception. : [Attachment 45258] Invalid url should raise SYNTAX_ERR exception.

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Fumitoshi Ukai
<ukai at chromium.org>'s request for review:
Bug 32700: WebSocket: Invalid url should raise SYNTAX_ERR exception.
https://bugs.webkit.org/show_bug.cgi?id=32700

Attachment 45258: Invalid url should raise SYNTAX_ERR exception.
https://bugs.webkit.org/attachment.cgi?id=45258&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> +static WebCore::String encodeProtocolString(const WebCore::String& protocol)


This is inside namespace WebCore, and doesn't need namespace prefixes. Please
fix before landing.

> +    const UChar* characters = protocol.characters();
> +    StringBuilder builder;
> +    for (size_t i = 0; i < protocol.length(); i++) {
> +	   if (characters[i] < 0x20 || characters[i] > 0x7E)

Why not just use protocol[i]?

r=me