[webkit-reviews] review denied: [Bug 32706] <noscript> is taking effect even though the Javascript is enabled, when XHTMLMP is enabled : [Attachment 45308] patch

[bugzilla-daemon at webkit.org]

Adam Treat <treat at kde.org> has denied Charles Wei
<charles.wei at torchmobile.com.cn>'s request for review:
Bug 32706: <noscript> is taking effect even though the Javascript is enabled,
when XHTMLMP is enabled
https://bugs.webkit.org/show_bug.cgi?id=32706

Attachment 45308: patch
https://bugs.webkit.org/attachment.cgi?id=45308&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
Can you programmatically turn on/off JavaScript and test rather than just
assume it is on and only test that case?  Also it isn't clear to me why the
change to HTMLParser should be XHTMLMP only... If JS is on, then noscript
should be skipped regardless of whether XHTMLMP is enabled or not, right? Also
what about the previous changes to HTMLNoSCriptElement?