[webkit-reviews] review requested: [Bug 32592] [check-webkit-style] Refactor cpp_style.parse_arguments so that it has no global variable side effects. : [Attachment 45317] Proposed patch 4

[bugzilla-daemon at webkit.org]

Chris Jerdonek <chris.jerdonek at gmail.com> has asked  for review:
Bug 32592: [check-webkit-style] Refactor cpp_style.parse_arguments so that it
has no global variable side effects.
https://bugs.webkit.org/show_bug.cgi?id=32592

Attachment 45317: Proposed patch 4
https://bugs.webkit.org/attachment.cgi?id=45317&action=review

------- Additional Comments from Chris Jerdonek <chris.jerdonek at gmail.com>
I noticed that the defaults were not getting set after the code move, so I
changed two lines of style.parse_arguments() to this:

    verbosity = _DEFAULT_VERBOSITY
    output_format = _DEFAULT_OUTPUT_FORMAT

I'm not sure how much this matters since it will be refactored away
momentarily.