[webkit-reviews] review requested: [Bug 32706] <noscript> is taking effect even though the Javascript is enabled, when XHTMLMP is enabled : [Attachment 45308] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Dec 20 23:46:47 PST 2009
Charles Wei <charles.wei at torchmobile.com.cn> has asked for review:
Bug 32706: <noscript> is taking effect even though the Javascript is enabled,
when XHTMLMP is enabled
https://bugs.webkit.org/show_bug.cgi?id=32706
Attachment 45308: patch
https://bugs.webkit.org/attachment.cgi?id=45308&action=review
------- Additional Comments from Charles Wei <charles.wei at torchmobile.com.cn>
This patch fixes the problem "contents inside <noscript> is taking effect even
when Javascript is enabled, this happens only when XHTMLMP is enabled".
<noscript> is enabled when XHTMLMP is enabled, but the implementation only
hides the contents inside <noscript> when Javascript is turned on, which is
incorrect.
The correct solution is to skip the parsing of all the contents inside
<noscript> if Javascript is turned on .
More information about the webkit-reviews
mailing list