[webkit-reviews] review requested: [Bug 32773] [check-webkit-style] Create a "styles" folder in Scripts/modules : [Attachment 45299] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 20 15:43:52 PST 2009

Chris Jerdonek <chris.jerdonek at gmail.com> has asked  for review:
Bug 32773: [check-webkit-style] Create a "styles" folder in Scripts/modules

Attachment 45299: Proposed patch

------- Additional Comments from Chris Jerdonek <chris.jerdonek at gmail.com>
I'm not sure how to proceed with this since it doesn't look like
svn-create-patch supports directory adds.

I would like a directory named "style" added to Scripts/modules.  The
style-related files can be moved/renamed in a subsequent patch.

After the comment discussion with Eric, it definitely seems worth separating
all of the style-related files from the other files in the modules folder, and
not just the style-related files having to do with file types (cpp_style.py,
text_style.py, etc).  And because there are only around 6 style-related files
in all, it doesn't seem necessary to create an additional sub-folder inside for
the file types.  That can always be done later, if necessary.

More information about the webkit-reviews mailing list