[webkit-reviews] review granted: [Bug 32803] Web Inspector: extract syntax highlighters into separate files. : [Attachment 45295] [PATCH] Pure split, no other changes.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 20 15:07:34 PST 2009


Eric Seidel <eric at webkit.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 32803: Web Inspector: extract syntax highlighters into separate files.
https://bugs.webkit.org/show_bug.cgi?id=32803

Attachment 45295: [PATCH] Pure split, no other changes.
https://bugs.webkit.org/attachment.cgi?id=45295&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
The big dictionaries all returnign "true" seem silly.  They shoudl just be
written as arrays but converted to dictionaries at runtime.

If this is just moving code than rs=me.


More information about the webkit-reviews mailing list