[webkit-reviews] review granted: [Bug 32780] Use memcache to make dashboard to fast : [Attachment 45255] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 32780: Use memcache to make dashboard to fast
https://bugs.webkit.org/show_bug.cgi?id=32780

Attachment 45255: Patch
https://bugs.webkit.org/attachment.cgi?id=45255&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
remove_api seems unrelated.

I don't see why you broke queue_name and bug_id out into local variables in
UpdateStatus

Why change it to use a regexp if we compile every time?
74	   regexp = re.compile("-")
 75	    return regexp.sub("_", dashed_name)

replace is simpler, no?

Why do we have 3 copies of the string "attachment-summary"?  Seems error prone.


Looks OK though.