[webkit-reviews] review canceled: [Bug 32772] Missing checks for Geolocation in Navigator.cpp : [Attachment 45238] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Dec 19 10:29:52 PST 2009


Philippe Normand <pnormand at igalia.com> has canceled Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 32772: Missing checks for Geolocation in Navigator.cpp
https://bugs.webkit.org/show_bug.cgi?id=32772

Attachment 45238: proposed patch
https://bugs.webkit.org/attachment.cgi?id=45238&action=review

------- Additional Comments from Philippe Normand <pnormand at igalia.com>
This patch is a bad workaround for the bug. The correct fix would be to readd
some of the files (including GeolocationService.cpp) in the build, even if
geolocation is disabled.


More information about the webkit-reviews mailing list