[webkit-reviews] review requested: [Bug 32770] [GTK] Spell check works on selection but it should work on unselected words : [Attachment 45239] Pass a string to Editor and make GTK+ not use the selected text but the text in the node.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Dec 19 10:01:35 PST 2009


Christian Dywan <christian at twotoasts.de> has asked  for review:
Bug 32770: [GTK] Spell check works on selection but it should work on
unselected words
https://bugs.webkit.org/show_bug.cgi?id=32770

Attachment 45239: Pass a string to Editor and make GTK+ not use the selected
text but the text in the node.
https://bugs.webkit.org/attachment.cgi?id=45239&action=review

------- Additional Comments from Christian Dywan <christian at twotoasts.de>
The patch allows the behaviour as described above, and the GTK+ port makes use
of it, while other ports behave as before. Note that I didn't fully port Mac
code paths in Editor to support the non-selection behaviour since they are not
used and I can't really test it. If you think it's useful anyhow and agree with
the approach, I can try to make the Mac changes.


More information about the webkit-reviews mailing list