[webkit-reviews] review requested: [Bug 32592] [check-webkit-style] Refactor cpp_style.parse_arguments so that it has no global variable side effects. : [Attachment 45227] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Dec 19 00:45:10 PST 2009


Chris Jerdonek <chris.jerdonek at gmail.com> has asked  for review:
Bug 32592: [check-webkit-style] Refactor cpp_style.parse_arguments so that it
has no global variable side effects.
https://bugs.webkit.org/show_bug.cgi?id=32592

Attachment 45227: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=45227&action=review

------- Additional Comments from Chris Jerdonek <chris.jerdonek at gmail.com>
Let me know if you want me to split this into two patches.

It looks longer than it really is because of some large deletes.

In any case, I just want to get it out there so you can see it in one piece. 
Thanks.


More information about the webkit-reviews mailing list