[webkit-reviews] review requested: [Bug 32763] [Chromium] Eliminate redundant data copy in GraphicsContext3D readback : [Attachment 45219] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 18 19:09:30 PST 2009

Kenneth Russell <kbr at google.com> has asked  for review:
Bug 32763: [Chromium] Eliminate redundant data copy in GraphicsContext3D

Attachment 45219: Patch

------- Additional Comments from Kenneth Russell <kbr at google.com>
Eliminated useless creation of a CGBitmapContext and from there a CGImage. Now
create CGImage directly from data. Also changed readPixels parameters and
CGImage alpha info to try to avoid byte swapping, and disabled interpolation
when drawing the GL content. Some test cases run twice as fast with these
changes, though more work is needed to achieve desired performance.

No test case; performance optimization only. Ran WebGL demos from Khronos site
to verify changes.

More information about the webkit-reviews mailing list