[webkit-reviews] review requested: [Bug 32745] Add IWebPreferencesPrivate::[set]AcceleratedCompositingEnabled : [Attachment 45192] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 18 15:07:46 PST 2009


Adam Roben (aroben) <aroben at apple.com> has asked  for review:
Bug 32745: Add IWebPreferencesPrivate::[set]AcceleratedCompositingEnabled
https://bugs.webkit.org/show_bug.cgi?id=32745

Attachment 45192: Patch
https://bugs.webkit.org/attachment.cgi?id=45192&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
Need a short description and bug URL (OOPS!)

Reviewed by NOBODY (OOPS!).

* Interfaces/IWebPreferencesPrivate.idl: Added
[set]AcceleratedCompositingEnabled.

* Interfaces/WebKit.idl: Touched to force a build.

* WebPreferenceKeysPrivate.h: Added
WebKitAcceleratedCompositingEnabledPreferenceKey.

* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings): Default accelerated
compositing to on.
(WebPreferences::setAcceleratedCompositingEnabled): Store the new
value.
(WebPreferences::acceleratedCompositingEnabled): If accelerated
compositing isn't available, return false. Otherwise, return the value
stored in preferences.

* WebPreferences.h: Added [set]AcceleratedCompositingAvailable.

* WebView.cpp:
(WebView::notifyPreferencesChanged): Just pass the value from
WebPreferences on down.
---
 7 files changed, 58 insertions(+), 3 deletions(-)


More information about the webkit-reviews mailing list