[webkit-reviews] review requested: [Bug 30457] Allow image requests started from unload handlers to outlive the page : [Attachment 45176] Attempt #3
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Dec 18 13:16:13 PST 2009
Nate Chapin <japhet at chromium.org> has asked for review:
Bug 30457: Allow image requests started from unload handlers to outlive the
page
https://bugs.webkit.org/show_bug.cgi?id=30457
Attachment 45176: Attempt #3
https://bugs.webkit.org/attachment.cgi?id=45176&action=review
------- Additional Comments from Nate Chapin <japhet at chromium.org>
Added ASSERTs in FrameLoader, reworked comments, removed assert in
loader::cancelRequests.
The frame for these types of requests is now stored in Request. You made a
good point, logically the frame should be decided each time a Request is
created (if needed of course). This, combined with the removal of the ASSERT
in loader::cancelRequests, removes the need for any changes to DocLoader, so I
reverted those changes.
More information about the webkit-reviews
mailing list