[webkit-reviews] review denied: [Bug 31875] QWebView: Impossible to make XMLHttpRequest from locally stored HTML page : [Attachment 45124] Proposed Patch

[bugzilla-daemon at webkit.org]

Laszlo Gombos <laszlo.1.gombos at nokia.com> has denied Carol Szabo
<carol.szabo at nokia.com>'s request for review:
Bug 31875: QWebView: Impossible to make XMLHttpRequest from locally stored HTML
page
https://bugs.webkit.org/show_bug.cgi?id=31875

Attachment 45124: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=45124&action=review

------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
I think the need for this API is quite evident. Excellent patch. 

Looks good to me but I think we can do better documenting the testcase. Please
create comments inside the code for the followings: 

 - function runTest() in test.html.
 - class CannedResponseNetworkReply - why do we need this how does it work
 - explanation on why these tests can not be implemented as LayoutTests.

You can maybe also get a better summary for this change/ChangeLog.

r-, only because of the lack of documentation.