[webkit-reviews] review denied: [Bug 32651] [Android] MainThreadAndroid introduces a layering violation by calling JavaSharedClient methods : [Attachment 45048] Patch 1 for Bug 32651
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Dec 18 10:08:30 PST 2009
David Levin <levin at chromium.org> has denied Steve Block
<steveblock at google.com>'s request for review:
Bug 32651: [Android] MainThreadAndroid introduces a layering violation by
calling JavaSharedClient methods
https://bugs.webkit.org/show_bug.cgi?id=32651
Attachment 45048: Patch 1 for Bug 32651
https://bugs.webkit.org/attachment.cgi?id=45048&action=review
------- Additional Comments from David Levin <levin at chromium.org>
r- per Sam's comment.
I think the right thing to do here is to move the implementation from WebCore
to wtf. Then have the WebCore version (if it is still needed) call the wtf
version.
> Index: WebCore/platform/android/PlatformBridge.h
> + static void EnqueueOnMainthread(void (*function)(void*), void* payload);
fwiw, bad casing "Mainthread"
More information about the webkit-reviews
mailing list