[webkit-reviews] review denied: [Bug 32698] [JSC] Date binding support : [Attachment 45128] Proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied TAMURA, Kent <tkent at chromium.org>'s
request for review:
Bug 32698: [JSC] Date binding support
https://bugs.webkit.org/show_bug.cgi?id=32698

Attachment 45128: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=45128&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    return "$value.isUndefinedOrNull() ?
std::numeric_limits<double>::quiet_NaN() :
static_cast<DateInstance*>($value.toObject(exec))->internalNumber()" if $type
eq "Date";

This isn't right. We can't just call toObject and then cast to DateInstance*
without some sort of type check. I also suggest considering putting this logic
into a function in JSDOMBinding.h and just have the generated code call the
function instead of putting the logic into the bindings generator.

I think the patch needs to include one use of this binding so we can implement
the test cases we'll need.