[webkit-reviews] review requested: [Bug 19456] [GTK] Editing capabilities : [Attachment 45143] Implement webkit_web_view_execute_command, command-executed, catch internal commands
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Dec 18 04:24:54 PST 2009
Christian Dywan <christian at twotoasts.de> has asked for review:
Bug 19456: [GTK] Editing capabilities
https://bugs.webkit.org/show_bug.cgi?id=19456
Attachment 45143: Implement webkit_web_view_execute_command, command-executed,
catch internal commands
https://bugs.webkit.org/attachment.cgi?id=45143&action=review
------- Additional Comments from Christian Dywan <christian at twotoasts.de>
I updated the patch since I noticed that commands coming from WebCore, ie.
through Javascript were not handled at all. So I added a shouldExecuteCommand
to EditorClient.
One remaining issue: for some reason internal commands have no command names.
More information about the webkit-reviews
mailing list