[webkit-reviews] review granted: [Bug 32660] Allow custom memory allocation control for inspector's classes : [Attachment 45063] proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Zoltan Horvath <zoltan at webkit.org>'s
request for review:
Bug 32660: Allow custom memory allocation control for inspector's classes
https://bugs.webkit.org/show_bug.cgi?id=32660

Attachment 45063: proposed patch
https://bugs.webkit.org/attachment.cgi?id=45063&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> -    class JavaScriptDebugServer : JSC::Debugger {
> +    class JavaScriptDebugServer : JSC::Debugger, public Noncopyable {

I think it would be better to change DEFINE_STATIC_LOCAL to use fastNew rather
than changing all the classes using it to inherit from Noncopyable and
FastAllocBase. I'm not sure why I didn't think of this earlier.

r=me on this, but it seems it would be worthwhile to do that