[webkit-reviews] review requested: [Bug 32638] [V8] V8CustomBinding.h should vanish. : [Attachment 45106] Generate header declarations for non-constructor callbacks

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 17 15:58:47 PST 2009


Nate Chapin <japhet at chromium.org> has asked  for review:
Bug 32638: [V8] V8CustomBinding.h should vanish.
https://bugs.webkit.org/show_bug.cgi?id=32638

Attachment 45106: Generate header declarations for non-constructor callbacks
https://bugs.webkit.org/attachment.cgi?id=45106&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
I didn't immediately see a good way to generate declarations for constructors,
so I left them in V8CustomBinding.h.  All the other callbacks are now declared
in their respective headers.

This patch is huge, but it's mostly renaming.


More information about the webkit-reviews mailing list