[webkit-reviews] review granted: [Bug 32674] Fix link failure on LTCG builds on Windows for chromium port : [Attachment 45103] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Dec 17 12:54:44 PST 2009
Eric Seidel <eric at webkit.org> has granted Marc-Antoine Ruel
<maruel at chromium.org>'s request for review:
Bug 32674: Fix link failure on LTCG builds on Windows for chromium port
https://bugs.webkit.org/show_bug.cgi?id=32674
Attachment 45103: Patch
https://bugs.webkit.org/attachment.cgi?id=45103&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
Yay! Thank you for the update ChangeLog.
I think I would have just made it a protected static member of
SVGStyledElement, the callsite in SVGFontFaceElement would not have had to
change.
But also think this is totally fine as a free function.
r+
More information about the webkit-reviews
mailing list