[webkit-reviews] review granted: [Bug 32666] AX: DRT needs to support URL for accessibility : [Attachment 45078] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 17 11:42:37 PST 2009


David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 32666: AX: DRT needs to support URL for accessibility
https://bugs.webkit.org/show_bug.cgi?id=32666

Attachment 45078: patch
https://bugs.webkit.org/attachment.cgi?id=45078&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
> Index: WebKitTools/ChangeLog
> Index: WebKitTools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp
> +JSStringRef AccessibilityUIElement::url()
> +{
> +    return 0;
> +}

Please add a FIXME.  Also, other "FIXME" methods that return JSStringRef use
JSStringCreateWithCharacters(0, 0) instead:

    // FIXME: implement
    return JSStringCreateWithCharacters(0, 0);

> Index: WebKitTools/DumpRenderTree/win/AccessibilityUIElementWin.cpp
> +JSStringRef AccessibilityUIElement::url()
> +{
> +    return 0;
> +}

Again, I think this should use JSStringCreateWithCharacters(0, 0):

    return JSStringCreateWithCharacters(0, 0);

r=me with these changes


More information about the webkit-reviews mailing list