[webkit-reviews] review denied: [Bug 32597] Check one space before end of line comments : [Attachment 45043] Check one space before end of line comments.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Dec 17 10:05:33 PST 2009
David Levin <levin at chromium.org> has denied Fumitoshi Ukai
<ukai at chromium.org>'s request for review:
Bug 32597: Check one space before end of line comments
https://bugs.webkit.org/show_bug.cgi?id=32597
Attachment 45043: Check one space before end of line comments.
https://bugs.webkit.org/attachment.cgi?id=45043&action=review
------- Additional Comments from David Levin <levin at chromium.org>
Shinichiro did a fine job of reviewing this patch.
r- for the removed test cases that Shinichiro noted.
One small additional comment below.
> diff --git a/WebKitTools/Scripts/modules/cpp_style.py
b/WebKitTools/Scripts/modules/cpp_style.py
> + and ((line[comment_position-1] not in string.whitespace)
> + or (line[comment_position-2] in string.whitespace)))):
I know this was a problem before but since you are changing these lines please
add spaces around the "-".
More information about the webkit-reviews
mailing list