[webkit-reviews] review requested: [Bug 32432] [Qt] Add support for touch events in QWebView and QGraphicsWebView : [Attachment 44908] Updated patch according to Simon's comments
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Dec 17 09:04:36 PST 2009
Benjamin Poulain <benjamin.poulain at nokia.com> has asked for review:
Bug 32432: [Qt] Add support for touch events in QWebView and QGraphicsWebView
https://bugs.webkit.org/show_bug.cgi?id=32432
Attachment 44908: Updated patch according to Simon's comments
https://bugs.webkit.org/attachment.cgi?id=44908&action=review
------- Additional Comments from Benjamin Poulain <benjamin.poulain at nokia.com>
>+ if (d->page && (event->type() == QEvent::TouchBegin
>+ || event->type() == QEvent::TouchEnd
>+ || event->type() == QEvent::TouchUpdate)) {
I think the indentation is not correct here.
Looks good otherwise.
More information about the webkit-reviews
mailing list