[webkit-reviews] review requested: [Bug 32663] Don't include all JSC headers everywhere : [Attachment 45070] patch

[bugzilla-daemon at webkit.org]

Benjamin Otte <otte at gnome.org> has asked  for review:
Bug 32663: Don't include all JSC headers everywhere
https://bugs.webkit.org/show_bug.cgi?id=32663

Attachment 45070: patch
https://bugs.webkit.org/attachment.cgi?id=45070&action=review

------- Additional Comments from Benjamin Otte <otte at gnome.org>
PlatformString.h included almost all of JSC via runtime/Identifier.h. This
patch gets rid of this include by forward-declaring the required classes
instead.
This reduces the build size of the object files on a Gtk debug build by 10%.
The resulting libwebkit.so gets 5% smaller.

Somebody should probably make sure it still compiles on mac and qt as
PlatformString.h pulled a lot of other headers that must now be included
manually (like the one math.h fix for Gtk I have in the patch).