[webkit-reviews] review granted: [Bug 32374] marquee with display:inline causes crash : [Attachment 45047] Patch v4

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 17 07:37:06 PST 2009


mitz at webkit.org has granted Shinichiro Hamaji <hamaji at chromium.org>'s request
for review:
Bug 32374: marquee with display:inline causes crash
https://bugs.webkit.org/show_bug.cgi?id=32374

Attachment 45047: Patch v4
https://bugs.webkit.org/attachment.cgi?id=45047&action=review

------- Additional Comments from mitz at webkit.org
> +RenderMarquee* HTMLMarqueeElement::renderMarquee() const
> +{
> +    if (renderer() && renderer()->hasLayer() &&
renderBoxModelObject()->layer()->marquee())
> +	   return renderBoxModelObject()->layer()->marquee();
> +    return 0;

You don’t need the “&& renderBoxModelObject()->layer()->marquee()” condition.


More information about the webkit-reviews mailing list