[webkit-reviews] review denied: [Bug 32610] Web Inspector: Links to source in CPU profiles should open Scripts (debugger) panel : [Attachment 45060] Proposed fix, comments addressed
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Dec 17 07:20:07 PST 2009
Pavel Feldman <pfeldman at chromium.org> has denied Mikhail Naganov
<mnaganov at chromium.org>'s request for review:
Bug 32610: Web Inspector: Links to source in CPU profiles should open Scripts
(debugger) panel
https://bugs.webkit.org/show_bug.cgi?id=32610
Attachment 45060: Proposed fix, comments addressed
https://bugs.webkit.org/attachment.cgi?id=45060&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
> + showSourceLineForURL: function(url, line)
> + {
> + this.showResource(WebInspector.resourceForURL(url));
You lose line information here. Rest is Ok.
More information about the webkit-reviews
mailing list