[webkit-reviews] review requested: [Bug 30457] Allow image requests started from unload handlers to outlive the page : [Attachment 44996] Attempt #2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 16 11:04:12 PST 2009
Nate Chapin <japhet at chromium.org> has asked for review:
Bug 30457: Allow image requests started from unload handlers to outlive the
page
https://bugs.webkit.org/show_bug.cgi?id=30457
Attachment 44996: Attempt #2
https://bugs.webkit.org/attachment.cgi?id=44996&action=review
------- Additional Comments from Nate Chapin <japhet at chromium.org>
I believe I either addressed or obsoleted all of your code concerns.
I renamed m_unloadEventBeingDispatched to m_isDispatchingUnloadEvent in this
patch, but I can break that into a separate patch too if you like
Finally, I didn't add any new tests yet. I wouldn't be surprised if they're
still needed, but since this patch is much less spread out than the first
attempt, I figured I'd ask a second opinion before actually going to the
trouble of writing them.
More information about the webkit-reviews
mailing list