[webkit-reviews] review granted: [Bug 32249] WebSocket test server handshake is not strict enough : [Attachment 44948] Update pywebsocket to 0.4.4 and make handshake checking stricter

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Yuzo Fujishima
<yuzo at google.com>'s request for review:
Bug 32249: WebSocket test server handshake is not strict enough
https://bugs.webkit.org/show_bug.cgi?id=32249

Attachment 44948: Update pywebsocket to 0.4.4 and make handshake checking
stricter
https://bugs.webkit.org/attachment.cgi?id=44948&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
 +    r'(WebSocket-Protocol: [\x20-\x7e]+\r\n)?'
> +    r'([Cc][Oo][Oo][Kk][Ii][Ee]:[^\r]*\r\n)*'
> +    r'([Cc][Oo][Oo][Kk][Ii][Ee]2:[^\r]*\r\n)?'
> +    r'([Cc][Oo][Oo][Kk][Ii][Ee]:[^\r]*\r\n)*'

You didn't address my comment about Cookie headers also being in restricted
WebSocket syntax. Like other headers, they are case sensitive, require one
space after colon, etc.

This doesn't correctly handle the case of multiple Cookie headers - that
deserves at least a FIXME comment, if not fixing right away.

> -	 version='0.4.3',
> +	 version='0.4.5',

ChangeLog should be fixed to say 0.4.5.

> MUST level applies for the way the client sends data, but not for the way the

> server examine the data.

Ok.

r=me. ChangeLog will need to be fixed when landing, and please consider further
improving Cookie handling in a future patch.