[webkit-reviews] review requested: [Bug 32550] [Qt] Implement combobox delegate for Qt : [Attachment 44983] Refactoring of class QWebPopup.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 16 09:11:36 PST 2009

Luiz Agostini <luiz.agostini at openbossa.org> has asked  for review:
Bug 32550: [Qt] Implement combobox delegate for Qt

Attachment 44983: Refactoring of class QWebPopup.

------- Additional Comments from Luiz Agostini <luiz.agostini at openbossa.org>
Class QWebPopup has been split in QtAbstractWebPopup and QtFallbackWebPopup.
Both new classes are now in corresponding files and files QWebPopup.* have been
Custom combo popup classes will inherit from QtAbstractWebPopup. It is not the
public API as it is
in WebCore and will not be visible by users of QtWebKit. It will be used in
implementation of
public QtWebKit combobox popup delegation API.
Class QtFallbackWebPopup inherits from QtAbstractWebPopup and implements the
currently used combobox popup.
It needs to be improved to provide standard features that are missing like
style or indentation.

More information about the webkit-reviews mailing list