[webkit-reviews] review denied: [Bug 32550] [Qt] Implement combobox delegate for Qt : [Attachment 44888] Correcting coding style

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 16 04:56:47 PST 2009


Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Luiz Agostini
<luiz.agostini at openbossa.org>'s request for review:
Bug 32550: [Qt] Implement combobox delegate for Qt
https://bugs.webkit.org/show_bug.cgi?id=32550

Attachment 44888: Correcting coding style
https://bugs.webkit.org/attachment.cgi?id=44888&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
QAbstractPopupMenu and QDefaultPopupMenu are bad names as they are Qt specific
WebCore classes, and not Qt public classes. In other places we have prefixes
these with Qt* instead.


More information about the webkit-reviews mailing list