[webkit-reviews] review requested: [Bug 32565] [Qt] Initialization of a new API; QJavaScript. : [Attachment 44961] Initialization of API v2

[bugzilla-daemon at webkit.org]

Jędrzej Nowacki <jedrzej.nowacki at nokia.com> has asked  for review:
Bug 32565: [Qt] Initialization of a new API; QJavaScript.
https://bugs.webkit.org/show_bug.cgi?id=32565

Attachment 44961: Initialization of API v2
https://bugs.webkit.org/attachment.cgi?id=44961&action=review

------- Additional Comments from Jędrzej Nowacki <jedrzej.nowacki at nokia.com>
I have added #include "config.h" add the beginning of each implementation file.


Another problem that will be pointed by bot:
JavaScriptCore/qt/api/qjavascriptvalue.cpp:22:	You should add a blank line
after implementation file's own header.  [build/include_order] [4]
JavaScriptCore/qt/api/qjavascriptengine.cpp:22:  You should add a blank line
after implementation file's own header.  [build/include_order] [4]
I think it is wrong as the file is an implementation of two classes (public and
private). I believe that the problem with sorting is caused by this
misunderstood. When I call sort for a new headers:
$ ls |grep .h |sort
qjavascriptengine.h
qjavascriptengine_p.h
qjavascriptvalue.h
qjavascriptvalue_p.h
qtjavascriptglobal.h
which is what i tried to put into .cpp and .h files