[webkit-reviews] review requested: [Bug 32538] [check-webkit-style] Add support for TAB check against text files : [Attachment 44944] Proposed patch (rev.2)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 15 22:53:21 PST 2009


TAMURA, Kent <tkent at chromium.org> has asked  for review:
Bug 32538: [check-webkit-style] Add support for TAB check against text files
https://bugs.webkit.org/show_bug.cgi?id=32538

Attachment 44944: Proposed patch (rev.2)
https://bugs.webkit.org/attachment.cgi?id=44944&action=review

------- Additional Comments from TAMURA, Kent <tkent at chromium.org>
Thank you for the comments. I followed them, and rewrote the code almost
entirely.

I understand we should move more code from cpp_style.py to the common module.
But I didn't it for now to avoid behavior change and refactoring at the same
time.


> > -- 
> > 1.6.3.3
>
> I'm not sure what's this :)

Please ignore it. It was a footer produced by "git format-patch"


More information about the webkit-reviews mailing list