[webkit-reviews] review denied: [Bug 32374] marquee with display:inline causes crash : [Attachment 44777] Patch v3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 15 09:07:19 PST 2009


mitz at webkit.org has denied Shinichiro Hamaji <hamaji at chromium.org>'s request
for review:
Bug 32374: marquee with display:inline causes crash
https://bugs.webkit.org/show_bug.cgi?id=32374

Attachment 44777: Patch v3
https://bugs.webkit.org/attachment.cgi?id=44777&action=review

------- Additional Comments from mitz at webkit.org
I don’t think this is correct. You should just not create a RenderMarquee for
an inline. Just change the condition in RenderLayer::styleChanged() to also
check that the renderer is a box.


More information about the webkit-reviews mailing list