[webkit-reviews] review granted: [Bug 30914] [Qt] Javascript Prompt API default return values check failure on QtLauncher : [Attachment 44845] Fix for Bug #30914

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 15 04:54:26 PST 2009


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Holger Freyther
<zecke at selfish.org>'s request for review:
Bug 30914: [Qt] Javascript Prompt API default return values check failure on
QtLauncher
https://bugs.webkit.org/show_bug.cgi?id=30914

Attachment 44845: Fix for Bug #30914
https://bugs.webkit.org/attachment.cgi?id=44845&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
LGTM, but there are a few things you might consider changing.

> +++ b/WebCore/manual-tests/qt/java-script-prompt.html

The manual tests doesn't look Qt specific. Is it? If it is not, we should move
it.

> -    result should be written to \a result and true should be returned.
> +    result should be written to \a result and true should be returned. If
the prompt was not cacelled by the

cancelled with an n. Please change this before landing.


More information about the webkit-reviews mailing list