[webkit-reviews] review requested: [Bug 30914] [Qt] Javascript Prompt API default return values check failure on QtLauncher : [Attachment 44845] Fix for Bug #30914

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 14 22:16:49 PST 2009


Holger Freyther <zecke at selfish.org> has asked  for review:
Bug 30914: [Qt] Javascript Prompt API default return values check failure on
QtLauncher
https://bugs.webkit.org/show_bug.cgi?id=30914

Attachment 44845: Fix for Bug #30914
https://bugs.webkit.org/attachment.cgi?id=44845&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
- Provide a manual test for this... so we can verify it in other browsers
- Document what the API user should do..
- Same fixup but only assign result once...


More information about the webkit-reviews mailing list