[webkit-reviews] review requested: [Bug 32479] Improve portability of LayoutTests/fast/forms/validationMessage.html : [Attachment 44831] Proposed patch (rev.2)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 14 18:29:29 PST 2009

TAMURA, Kent <tkent at chromium.org> has asked  for review:
Bug 32479: Improve portability of LayoutTests/fast/forms/validationMessage.html

Attachment 44831: Proposed patch (rev.2)

------- Additional Comments from TAMURA, Kent <tkent at chromium.org>
* Fixed typos
* Removed TABs
* Removed whitespace-only lines in ChangeLog

(In reply to comment #3)
> (From update of attachment 44750 [details])
> These messages are not something I want to see different between different
> WebKit platforms. The real issue here is language, not platform. HTML5
> that these be localized strings, and since WebKit localization is left up to
> each platform, that means each platform defines these strings. But that does
> not mean platforms should innovate on the string values!
> I think that as a project WebKit should strive to use the same messages here
> all platforms for a given language. DumpRenderTree just needs some way to
> sure it tests the English-language version. So I think the "platform
> independence" here, and the plan for multiple expected files, is not the
> direction.

It's not hard to use same English messages in all platforms.  But how about
other languages?  Is it possible to have same messages for non-English in all
I don't think it's practical.
There is a WebKit browser which has only Japanese version. Your "same message"
rule doesn't work with it.

More information about the webkit-reviews mailing list