[webkit-reviews] review granted: [Bug 32464] [bzt] Kill LandingSequence : [Attachment 44728] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 32464: [bzt] Kill LandingSequence
https://bugs.webkit.org/show_bug.cgi?id=32464

Attachment 44728: Patch
https://bugs.webkit.org/attachment.cgi?id=44728&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Now we'll need to test the input/output state of each command.	Seems this
would be easier to test if they were in fact exactly that.  input = {} and
output = {}.  Do we ever need output to persist across comamnds?  e.g. that
command1 produces output that command3 uses, but command2 ignores?  Donno.

Spacing?
 196	     state = {"patch": patch}

I would have put spaces after { and before }... but maybe the PEP says
something here?  Also I would have put a space before :

Seems like Command should expose a run_and_handle_errors method, which calls
through to the _sequence method.

Looks OK though.  Would be good to figure out what the official spacing is
supposed to be, since your spacing here is inconsistent with at least the code
that I have written in modules/*.py