[webkit-reviews] review requested: [Bug 32295] Typing in Wave repaints the whole screen : [Attachment 44825] better patch and test

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has asked	for review:
Bug 32295: Typing in Wave repaints the whole screen
https://bugs.webkit.org/show_bug.cgi?id=32295

Attachment 44825: better patch and test
https://bugs.webkit.org/attachment.cgi?id=44825&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
This patch is slightly better since it avoids doing another walk through the
RenderBlock's children.  I've also avoided changing when fullLayout is set in
preference for changing when the RenderBlock is mutated.

I'd greatly appreciate some input on what this code is supposed to be doing. 
There seem to be a lot of signals used to indicate that a RenderBlock needs to
have some or all of its lineboxes regenerated:

RenderBlock::m_needsLayout
RenderBlock::firstLineBox() == NULL
RenderText::m_linesDirty
InlineBox::m_dirty

but I can't figure out which should be set under which circumstances.