[webkit-reviews] review granted: [Bug 32455] [V8] Indexers and named propery getters should be generated : [Attachment 44817] Generate bindings for trivial indexers.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 14 13:59:12 PST 2009


Eric Seidel <eric at webkit.org> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 32455: [V8] Indexers and named propery getters should be generated
https://bugs.webkit.org/show_bug.cgi?id=32455

Attachment 44817: Generate bindings for trivial indexers.
https://bugs.webkit.org/attachment.cgi?id=44817&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
It would be nice to see an example of the new generated code.  But this looks
OK as far as I can tell.  Are you sure we have tests covering index getters for
all these?


More information about the webkit-reviews mailing list