[webkit-reviews] review requested: [Bug 5578] WebKit does not support DOM Level 3 setIsId and isId : [Attachment 44812] new patch to handle isId only

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 14 12:27:48 PST 2009


Chang Shu <Chang.Shu at nokia.com> has asked  for review:
Bug 5578: WebKit does not support DOM Level 3 setIsId and isId
https://bugs.webkit.org/show_bug.cgi?id=5578

Attachment 44812: new patch to handle isId only
https://bugs.webkit.org/attachment.cgi?id=44812&action=review

------- Additional Comments from Chang Shu <Chang.Shu at nokia.com>
Finally after weeks of scattered work, I finished this patch to implement isId
functionality. I basically added the isId interface and implementation in class
Element. I also replaced all the instances of idAttr in the code with
idAttributeName(), where customized id name may be returned after
implementation is done in the next patch. So far, it always returns "id". For
almost each of the above changes, I either created a new test case or used an
existing one. These test cases will be enhanced to test customized id names in
the next patch.


More information about the webkit-reviews mailing list