[webkit-reviews] review denied: [Bug 32479] Improve portability of LayoutTests/fast/forms/validationMessage.html : [Attachment 44750] Proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied TAMURA, Kent <tkent at chromium.org>'s
request for review:
Bug 32479: Improve portability of LayoutTests/fast/forms/validationMessage.html
https://bugs.webkit.org/show_bug.cgi?id=32479

Attachment 44750: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=44750&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
These messages are not something I want to see different between different
WebKit platforms. The real issue here is language, not platform. HTML5 suggests
that these be localized strings, and since WebKit localization is left up to
each platform, that means each platform defines these strings. But that does
not mean platforms should innovate on the string values!

I think that as a project WebKit should strive to use the same messages here on
all platforms for a given language. DumpRenderTree just needs some way to make
sure it tests the English-language version. So I think the "platform
independence" here, and the plan for multiple expected files, is not the right
direction.

Now on to specific comments:

The patch has some tabs in it.

> +// Because the valdiation messages can be port-dependent, we should

Typo: "valdiation".

> +debug('Tests for eleemnts without validation support:');

Typo: "eleemnts".

review- because of the tabs