[webkit-reviews] review denied: [Bug 32511] Dragging an SVG image triggers assertion in DragController::startDrag() : [Attachment 44788] Add SVGImage::filenameExtension()

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Andreas Kling
<andreas.kling at nokia.com>'s request for review:
Bug 32511: Dragging an SVG image triggers assertion in
DragController::startDrag()
https://bugs.webkit.org/show_bug.cgi?id=32511

Attachment 44788: Add SVGImage::filenameExtension()
https://bugs.webkit.org/attachment.cgi?id=44788&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Thanks, looks like the right fix.

> +	   virtual String filenameExtension() const;

Virtual functions like this one normally should be private rather than public.
It's a programming error to call this function on a pointer known to be an
SVGImage* so it's good to get a compiler error in that case. And a private
member function still does just fine at overriding the base class.

Can we make a regression test for this? Normally we require regression tests
for all bug fixes, and we have quite a few dragging tests already, so it can
probably be done.

I'm going to say review-, but if you try and find we can't make a regression
test then revise the ChangeLog to explain why, and then feel free to put this
up for review again.