[webkit-reviews] review granted: [Bug 30366] if the QWebPage is rendered by a QGraphicsWidget child of another widget with ItemClipsChildrenToShape the scrollbar is not clipped : [Attachment 44478] updated patch

[bugzilla-daemon at webkit.org]

Marco Martin <notmart at gmail.com> has granted  review:
Bug 30366: if the QWebPage is rendered by a QGraphicsWidget child of another
widget with ItemClipsChildrenToShape the scrollbar is not clipped
https://bugs.webkit.org/show_bug.cgi?id=30366

Attachment 44478: updated patch
https://bugs.webkit.org/attachment.cgi?id=44478&action=review

------- Additional Comments from Marco Martin <notmart at gmail.com>
> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog (revision 51868)
> +++ WebCore/ChangeLog (working copy)
> @@ -1,3 +1,19 @@
> +2009-12-08  Marco Martin  <notmart at gmail.com>
> +
> +	   Review pending.
> +
> +	   In the Scrollbar painting of the Qt theme integration,
> +	   intersects any previous clip rects with the one needed to paint the
scrollbar.
> +	   This fixes the painting in QGraphicsview, when the parent of the
widget that 
> +	   paints the QWebPage has the QGraphicsItem::ItemClipsChildrenToShape
set and
> +	   a piece of the scrollbar should be cipped away
> +	   https://bugs.webkit.org/show_bug.cgi?id=30366
> +
> +	   No new tests.
> +
> +	   * platform/qt/ScrollbarThemeQt.cpp:
> +	   (WebCore::ScrollbarThemeQt::paint):
> +
>  2009-12-08  John Gregg  <johnnyg at google.com>
>  
>	   Reviewed by Adam Barth.
> Index: WebCore/platform/qt/ScrollbarThemeQt.cpp
> ===================================================================
> --- WebCore/platform/qt/ScrollbarThemeQt.cpp	(revision 51865)
> +++ WebCore/platform/qt/ScrollbarThemeQt.cpp	(working copy)
> @@ -147,7 +147,7 @@
>      p.painter->save();
>      QStyleOptionSlider* opt = styleOptionSlider(scrollbar, p.widget);
>  
> -    p.painter->setClipRect(opt->rect.intersected(damageRect));
> +    p.painter->setClipRect(opt->rect.intersected(damageRect),
Qt::IntersectClip);
>  
>  #ifdef Q_WS_MAC
>      p.drawComplexControl(QStyle::CC_ScrollBar, *opt);