[webkit-reviews] review canceled: [Bug 32437] [Qt] [LayoutTestController]Output of document.write() is vanished by waitUntilDone()/notifyDone() : [Attachment 44763] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 14 06:12:44 PST 2009


robert <robert at roberthogan.net> has canceled robert <robert at roberthogan.net>'s
request for review:
Bug 32437: [Qt] [LayoutTestController]Output of document.write() is vanished by
waitUntilDone()/notifyDone()
https://bugs.webkit.org/show_bug.cgi?id=32437

Attachment 44763: Patch
https://bugs.webkit.org/attachment.cgi?id=44763&action=review

------- Additional Comments from robert <robert at roberthogan.net>
I think m_isLoading is better off named as m_hasDumped and set to false when
the test starts. With the introduction of m_loadFinished, it's purpose is to
check whether DRT still needs to dump the results or not.


More information about the webkit-reviews mailing list