[webkit-reviews] review requested: [Bug 32295] Typing in Wave repaints the whole screen : [Attachment 44772] Strawman patch that adds a finer-grained check for the fullLayout flag

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has asked	for review:
Bug 32295: Typing in Wave repaints the whole screen
https://bugs.webkit.org/show_bug.cgi?id=32295

Attachment 44772: Strawman patch that adds a finer-grained check for the
fullLayout flag
https://bugs.webkit.org/attachment.cgi?id=44772&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
This patch adds a check in RenderBlock::layoutInlineChildren() to try to
differentiate the case of a RenderBlock having no firstLineBox() because line
boxes need to be regenerated and having no firstLineBox() because it does not
need any (i.e. all of its children are positioned or floats).  I do not think
this patch is the best possible solution and I think it needs some additional
tests, but I'd appreciate feedback from people more knowledgeable about this
code on the general approach.  I think this codepath is actually getting hit
quite often since this fairly common idiom will cause it:

<div style="position:relative; height:600px; width:900px; overflow:hidden;" >
  <div style="position:absolute; height:600px; width:1000px; left:50px;">
    stuff that should be trimmed
  </div>
</div>