[webkit-reviews] review requested: [Bug 32487] [check-webkit-style] cpp_style.py contains code redundant with check-webkit-style : [Attachment 44759] Proposed patch 2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Dec 13 12:34:39 PST 2009
Chris Jerdonek <chris.jerdonek at gmail.com> has asked for review:
Bug 32487: [check-webkit-style] cpp_style.py contains code redundant with
check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=32487
Attachment 44759: Proposed patch 2
https://bugs.webkit.org/attachment.cgi?id=44759&action=review
------- Additional Comments from Chris Jerdonek <chris.jerdonek at gmail.com>
Tweaked previous patch:
- Changed double quotes to single quotes in _STYLE_CATEGORIES.
- Also changed global "FILTER" references to "FILTER_RULES".
This is because there was confusion in using "filter" to refer
both to an individual filter rule (e.g. "+foo") as well as to
the filter resulting from a list of such rules (a filter
being a list of filters). Instead I chose to use "filter" for
the collective rule and "filter rule" for the individual
boolean rules making up a filter.
More information about the webkit-reviews
mailing list