[webkit-reviews] review requested: [Bug 29008] Add a test in Qt for https://bugs.webkit.org/show_bug.cgi?id=29005 : [Attachment 44756] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 13 07:28:02 PST 2009


Benjamin Poulain <benjamin.poulain at nokia.com> has asked  for review:
Bug 29008: Add a test in Qt for https://bugs.webkit.org/show_bug.cgi?id=29005
https://bugs.webkit.org/show_bug.cgi?id=29008

Attachment 44756: Patch
https://bugs.webkit.org/attachment.cgi?id=44756&action=review

------- Additional Comments from Benjamin Poulain <benjamin.poulain at nokia.com>
> The coding style says that this brace should be placed on the preceeding
line.
> 
> Otherwise the patch looks good! (sorry about the style nitpick ;(

Thanks for the review...on Saturday! :)

This is the same patch with the curly bracket on the same line as the class
name. Only 8 class definitions of the autotests follow this style, out of 34
classes. I'll have a look at that as part of 32216.


More information about the webkit-reviews mailing list