[webkit-reviews] review granted: [Bug 30055] Bad DOM performance in large SVG files : [Attachment 41379] Paint RenderPath only when necessary

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Dec 12 23:22:34 PST 2009


Oliver Hunt <oliver at apple.com> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 30055: Bad DOM performance in large SVG files
https://bugs.webkit.org/show_bug.cgi?id=30055

Attachment 41379: Paint RenderPath only when necessary
https://bugs.webkit.org/attachment.cgi?id=41379&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
I found another testcase where we get pathologically bad perf due to this issue
which would imply that there's just too much cost in not clipping prior to
calling the graphics library -- my test case just created many many many
(~50000 odd) nodes mostly off the screen and this patch represents a huge
improvement in that case.

Still not sure why i don't see the perf problems you do in your example, but
with a testcase that is too slow this shows up as a clear problem in shark.

r=me.

The patch applies cleanly lets see how the commit bot deals with the changelog.


More information about the webkit-reviews mailing list