[webkit-reviews] review denied: [Bug 29008] Add a test in Qt for https://bugs.webkit.org/show_bug.cgi?id=29005 : [Attachment 39142] patch suggestion
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Dec 12 16:09:32 PST 2009
Simon Hausmann <hausmann at webkit.org> has denied Benjamin Poulain
<benjamin.poulain at nokia.com>'s request for review:
Bug 29008: Add a test in Qt for https://bugs.webkit.org/show_bug.cgi?id=29005
https://bugs.webkit.org/show_bug.cgi?id=29008
Attachment 39142: patch suggestion
https://bugs.webkit.org/attachment.cgi?id=39142&action=review
------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
> +class StringListTestObject : public QObject
> +{
The coding style says that this brace should be placed on the preceeding line.
Otherwise the patch looks good! (sorry about the style nitpick ;(
More information about the webkit-reviews
mailing list